Conversation
tlopex
approved these changes
Sep 24, 2026
tqchen
force-pushed
the
script/annotation-symbol-capture
branch
2 times, most recently
from
September 25, 2026 00:36
34f6b17 to
b681f6e
Compare
Share scope-independent dynamic symbol construction between I and T, and replace implicit body declarations with explicit captures or typed function parameters. Preserve dtype information in scalar annotations and print symbols without reconstructing them from body assignments.
Remove expression-string policies and implicit symbolic lookup from the parser and eager constructors. Keep whole annotation decoding and generic annotation adaptation, and print concrete expressions with explicit dynamic symbols.
Declare symbolic dimensions and strides explicitly in script callers, intrinsic factories, and examples. Keep independent function symbols distinct and preserve shared captures and deferred whole annotations.
tqchen
force-pushed
the
script/annotation-symbol-capture
branch
from
September 25, 2026 01:30
b681f6e to
9e40422
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #20438.
Read explicit annotation symbols directly instead of wrapping each name in
require_definedandannotation_value_. Snapshot the free definition bindings once, preserving lazy missing-name errors and separation from parameter and body scopes.Remove captured runtime
typing.TypeVaradaptation. Local generic symbols use PEP 695 headers with deferred whole annotations; external symbols use concreteI.dynamic/T.dynamicvalues. Keep annotation classes, Python unions, and deferred return-constructor normalization.Bind a scalar parameter to an existing native symbol explicitly with
n: n. An independently typed parameter such asn: T.int32shadows an outer symbol without an annotation-read registration side effect. Ordinary body locals may shadow definition captures; explicit header declarations retain symbolic reassignment diagnostics.Global-info selectors use the builder resolver decorator after ordinary argument evaluation. Remove the obsolete parser argument-policy registry while retaining deferred whole annotations and concrete symbolic dimensions. The S-TIR namespace shares scalar annotation metadata and concrete dynamic constructors with TIRx.